Skip to content

chore: Add combined browser package. #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 4, 2025
Merged

chore: Add combined browser package. #871

merged 10 commits into from
Jun 4, 2025

Conversation

@kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented May 22, 2025

Scaffolds the combined browser package. This is a package with pre-configured observability.

@kinyoklion kinyoklion force-pushed the rlamb/add-combined-browser-package branch from ba90cf8 to a67c23b Compare May 22, 2025 20:13
@kinyoklion kinyoklion force-pushed the rlamb/add-combined-browser-package branch from a67c23b to b443439 Compare May 22, 2025 20:14
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 24867 bytes
Size limit: 26000

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025 •
edited
Loading

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 16055 bytes
Size limit: 20000

@kinyoklion kinyoklion changed the title chore: Scaffold combined browser package. feat: Add combined browser package. May 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025 •
edited
Loading

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 21212 bytes
Size limit: 25000

@kinyoklion kinyoklion changed the title feat: Add combined browser package. chore: Add combined browser package. May 22, 2025
@kinyoklion kinyoklion force-pushed the rlamb/add-combined-browser-package branch from 1e4b0fa to 4a0e99f Compare May 22, 2025 20:18
@kinyoklion kinyoklion marked this pull request as ready for review May 22, 2025 20:19
@kinyoklion kinyoklion requested a review from a team as a code owner May 22, 2025 20:19
@kinyoklion kinyoklion marked this pull request as draft May 22, 2025 20:22
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025 •
edited
Loading

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Size: 168949 bytes
Size limit: 200000

@kinyoklion kinyoklion marked this pull request as ready for review May 22, 2025 20:44
kinyoklion
kinyoklion commented May 22, 2025
View reviewed changes
@kinyoklion
Copy link
Member Author

kinyoklion commented May 22, 2025

@launchdarkly/browser size report This is the brotli compressed size of the ESM build. Size: 167493 bytes Size limit: 200000

Went with 200k here which is very arbitrary.

@kinyoklion kinyoklion requested a review from Vadman97 May 22, 2025 21:02
kinyoklion
kinyoklion commented May 22, 2025
View reviewed changes
README.md
| [@launchdarkly/react-native-client-sdk](packages/sdk/react-native/README.md) | [![NPM][sdk-react-native-npm-badge]][sdk-react-native-npm-link] | [React-Native][package-sdk-react-native-issues] | [![Actions Status][sdk-react-native-ci-badge]][sdk-react-native-ci] |
| [@launchdarkly/js-client-sdk](packages/sdk/browser/README.md) | [![NPM][sdk-browser-npm-badge]][sdk-browser-npm-link] | [Browser][package-sdk-browser-issues] | [![Actions Status][sdk-browser-ci-badge]][sdk-browser-ci] |
| [@launchdarkly/server-sdk-ai](packages/sdk/server-ai/README.md) | [![NPM][sdk-server-ai-npm-badge]][sdk-server-ai-npm-link] | [server-ai][package-sdk-server-ai-issues] | [![Actions Status][sdk-server-ai-ci-badge]][sdk-server-ai-ci] |
<!--| [@launchdarkly/browser](packages/sdk/combined-browser/README.md) | [![NPM][sdk-combined-browser-npm-badge]][sdk-browser-npm-link] | [Combined Browser][package-sdk-combined-browser-issues] | [![Actions Status][sdk-combined-browser-ci-badge]][sdk-combined-browser-ci] |-->
Copy link
Member Author

@kinyoklion kinyoklion May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be un-commented once packages are published.

Vadman97
Vadman97 approved these changes May 23, 2025
View reviewed changes
Copy link

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me 🚢

packages/sdk/combined-browser/src/index.ts
Comment on lines +65 to +66
new Observability(options?.tmpProjectId ?? '1', options?.observability),
new SessionReplay(options?.tmpProjectId ?? '1', options?.sessionReplay),
Copy link

@Vadman97 Vadman97 May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could release this with sending the clientSideId as the project ID - i have the work in flight to start supporting that so by the time this is released we can test that

tanderson-ld
tanderson-ld approved these changes May 29, 2025
View reviewed changes
@tanderson-ld tanderson-ld self-requested a review May 29, 2025 15:11
@kinyoklion kinyoklion merged commit 3eeecf6 into main Jun 4, 2025
27 checks passed
@kinyoklion kinyoklion deleted the rlamb/add-combined-browser-package branch June 4, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vadman97 Vadman97 Vadman97 approved these changes

@tanderson-ld tanderson-ld Awaiting requested review from tanderson-ld

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kinyoklion @Vadman97 @tanderson-ld